Bump rubocop from 1.35.1 to 1.36.0 #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.35.1 to 1.36.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.35.1...v1.36.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/bundler/rubocop-1.36.0
branch
from
9cb1e43 to
ae342e0
Compare
dependabot
bot
added
dependencies
|
@rafaelfranca we already have |
bundle exec rake config:dump
sambostock
reviewed
Sep 6, 2022
test/fixtures/full_config.yml
Outdated
| @@ -2355,6 +2357,7 @@ Style/CaseEquality: | |||
| VersionAdded: '0.9' | |||
| VersionChanged: '0.89' | |||
| AllowOnConstant: true | |||
| AllowOnSelfClass: false | |||
There was a problem hiding this comment.
-
AllowOnConstant, which is enabled above, permitsSomeConstant === object
-
AllowOnSelfClassif enabled, would permitself.class === object
Let's enable it. |
sambostock
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rubocop from 1.35.1 to 1.36.0.
Release notes
Sourced from rubocop's releases.
Changelog
Sourced from rubocop's changelog.
Commits
3b3c5f5Cut 1.36ac98c75Update Changelog78eb21eAdd a spec for server modeca5b3c3Merge pull request #10984 from r7kamura/feature/modifier-exampleaad6aaaImprove singleton method example onLint/UselessAccessModifiercop2fb4c3cFix an error forrake prof:slow_cops65cec7cMerge pull request #10928 from r7kamura/feature/each3088078Merge pull request #10981 from Tietew/fix_a_false_positive_for_style_redundan...0780cb5Merge pull request #10932 from koic/use_official_jruby_image45403e3[Fix #10979] Fix a false positive forStyle/Style/RedundantParenthesesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)