Merge pull request #422 from Shopify/match_with_style_guide

Match rubocop-shopify with style guide recommendations
Shopify · Jul 25, 2022 · 9655ee8 · 9655ee8
2 parents b183fcb + 57446ff
commit 9655ee8
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 4 deletions.
diff --git a/rubocop.yml b/rubocop.yml
@@ -723,3 +723,8 @@ Style/WordArray:
 
 Style/YodaCondition:
   Enabled: false
+
+Style/ClassMethodsDefinitions:
+  EnforcedStyle: self_class
+  Enabled: true
+
diff --git a/test/fixtures/full_config.yml b/test/fixtures/full_config.yml
@@ -2368,9 +2368,9 @@ Style/ClassMethodsDefinitions:
   Description: Enforces using `def self.method_name` or `class << self` to define
     class methods.
   StyleGuide: "#def-self-class-methods"
-  Enabled: false
+  Enabled: true
   VersionAdded: '0.89'
-  EnforcedStyle: def_self
+  EnforcedStyle: self_class
   SupportedStyles:
   - def_self
   - self_class

diff --git a/test/test_helper.rb b/test/test_helper.rb
@@ -4,8 +4,10 @@
 require "pry-byebug"
 
 module Warning
-  def self.warn(message)
-    raise message.to_s
+  class << self
+    def warn(message)
+      raise message.to_s
+    end
   end
 end
 Warning[:deprecated] = true