Fix message

Shopify · Jan 2, 2024 · d77ee4f · d77ee4f
1 parent c63e7fb
commit d77ee4f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/lib/rubocop/cop/sorbet/signatures/void_checked_tests.rb b/lib/rubocop/cop/sorbet/signatures/void_checked_tests.rb
@@ -39,10 +39,10 @@ class VoidCheckedTests < ::RuboCop::Cop::Base
         PATTERN
 
         MESSAGE =
-          "The return value in a `.void.checked(:tests)` makes test behavior " \
-            "diffferent from non-test behavior. Either use " \
-            "`.returns(T.anything).checked(:tests)` to keep checking in tests, " \
-            "or `.void.checked(:never)` to leave the return completely untouched."
+          "Returning `.void` from a sig marked `.checked(:tests)` means that the" \
+            "method will return a different value in non-test environments (possibly" \
+            "with different truthiness). Either use `.returns(T.anything).checked(:tests)`" \
+            "to keep checking in tests, or `.void.checked(:never)` to leave it untouched."
         private_constant(:MESSAGE)
 
         private def top_level_void(node)

diff --git a/spec/rubocop/cop/sorbet/signatures/void_checked_tests_spec.rb b/spec/rubocop/cop/sorbet/signatures/void_checked_tests_spec.rb
@@ -4,10 +4,10 @@
 
 RSpec.describe(RuboCop::Cop::Sorbet::VoidCheckedTests, :config) do
   def message
-    "The return value in a `.void.checked(:tests)` makes test behavior " \
-      "diffferent from non-test behavior. Either use " \
-      "`.returns(T.anything).checked(:tests)` to keep checking in tests, " \
-      "or `.void.checked(:never)` to leave the return completely untouched."
+    "Returning `.void` from a sig marked `.checked(:tests)` means that the" \
+      "method will return a different value in non-test environments (possibly" \
+      "with different truthiness). Either use `.returns(T.anything).checked(:tests)`" \
+      "to keep checking in tests, or `.void.checked(:never)` to leave it untouched."
   end
 
   describe("offenses") do