Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tsc errors in README example #142

Merged
merged 2 commits into from
Mar 27, 2022

Conversation

sbalay
Copy link
Contributor

@sbalay sbalay commented Mar 25, 2022

Summary

Fixes tsc errors thrown in one of the advanced examples in the README

Further details: #141

Copy link
Contributor

@jamesism jamesism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sbalay sbalay marked this pull request as ready for review March 27, 2022 07:26
@sbalay sbalay merged commit 1ec98a8 into master Mar 27, 2022
@sbalay sbalay deleted the chore/fix-tsc-errors-in-readme-example branch March 27, 2022 07:26
@shopify-shipit shopify-shipit bot temporarily deployed to production April 11, 2022 07:28 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants