fix: Variant build stylesheet for RNW #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix a bug on RNW, which consists in incorrect styles generation for variants. The issue is also mentioned here by @chris24elias
It happened after #94 fix, which introduced use of StyleSheet.create in buildStyle, however for createVariant this is causing incorrect styles resolution.
It can be seen in this codesanbox
Checked this fix on the web, and variants are working as expected, with atomic classes being generated. And on RN everything works as expected.
I understand that this library doesn't have official support for RNW, but would be nice to have variants working on the web.