-
Notifications
You must be signed in to change notification settings - Fork 2
Move more internal components into util
folder
#33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
// The flexible array always allocates, but it's okay. | ||
// This struct is not allocated when the `rbs_loc` doesn't have children. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside, but this is a weird comment. There is no flexible array member here (that would be rbs_loc_entry entries[]
), and there's no allocation there, either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW this is the PR introduced the usage: ruby#1786
Assuming the top-level
include/rbs
holds public components (e.g.parser.h
), andinclude/rbs/util
holds internal components, more stuff should be moved underutil
.This follows the same convention
prism
uses.Before
After