Rename position, token, and rangetypes
#30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
approved these changes
Mar 28, 2025
st0012
force-pushed
the
rename-lexer-types
branch
from
7be7ddc to
3df96a9
Compare
Morriar
reviewed
Apr 4, 2025
| position pos = { 0, char_pos, -1, -1 }; | ||
| return pos; | ||
| rbs_position_t rbs_loc_position(int char_pos) { | ||
| return (rbs_position_t) { 0, char_pos, -1, -1 }; |
There was a problem hiding this comment.
We could be calling rbs_loc_position3 while at it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These names are too generic and can easily conflict in projects. New names are:
rbs_position_trbs_range_trbs_token_t