Fix code that triggers warnings when compiled with Sorbet #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st0012
changed the title
node variables in rbs_node_destroy's template
amomchilov
approved these changes
Mar 12, 2025
Such declarations will fail Sorbet's compiler:
```
prism/templates/src/ast.c.erb:203:31: error: unused variable 'node' [-Werror,-Wunused-variable]
rbs_ast_annotation_t *node = (rbs_ast_annotation_t *)any_node;
^
prism/templates/src/ast.c.erb:203:28: error: unused variable 'node' [-Werror,-Wunused-variable]
rbs_ast_comment_t *node = (rbs_ast_comment_t *)any_node;
^
prism/templates/src/ast.c.erb:203:28: error: unused variable 'node' [-Werror,-Wunused-variable]
rbs_ast_integer_t *node = (rbs_ast_integer_t *)any_node;
^
prism/templates/src/ast.c.erb:203:27: error: unused variable 'node' [-Werror,-Wunused-variable]
rbs_ast_string_t *node = (rbs_ast_string_t *)any_node;
^
```
- Use `size_t` instead of `int` for `capacity` in `rbs_loc_alloc_children` This fixes a warning about comparing `int` and `size_t` in `rbs_loc_alloc_children`'s assertion. - Avoid declaring the `max` variable that's just used in assertions. When the `assert` is stripped out, the variable becomes unused and triggers a warning.
st0012
force-pushed
the
avoid-declaring-unused-variables
branch
from
541cbe4 to
55fb761
Compare
st0012
added a commit
that referenced
this pull request
Mar 13, 2025
### Avoid declaring unused `node` variables in `rbs_node_destroy`'s template
Such declarations will fail Sorbet's compiler:
```
prism/templates/src/ast.c.erb:203:31: error: unused variable 'node' [-Werror,-Wunused-variable]
rbs_ast_annotation_t *node = (rbs_ast_annotation_t *)any_node;
^
prism/templates/src/ast.c.erb:203:28: error: unused variable 'node' [-Werror,-Wunused-variable]
rbs_ast_comment_t *node = (rbs_ast_comment_t *)any_node;
^
prism/templates/src/ast.c.erb:203:28: error: unused variable 'node' [-Werror,-Wunused-variable]
rbs_ast_integer_t *node = (rbs_ast_integer_t *)any_node;
^
prism/templates/src/ast.c.erb:203:27: error: unused variable 'node' [-Werror,-Wunused-variable]
rbs_ast_string_t *node = (rbs_ast_string_t *)any_node;
^
```
### Use `size_t` instead of `int` for `capacity` in `rbs_loc_alloc_children`
This fixes a warning about comparing `int` and `size_t` in `rbs_loc_alloc_children`'s assertion.
### Avoid declaring the `max` variable that's just used in assertions
When the `assert` is stripped out, the variable becomes unused and triggers a warning.
```
external/rbs_parser/src/rbs_location.c:8:10: warning: unused variable 'max' [-Wunused-variable]
size_t max = sizeof(rbs_loc_entry_bitmap) * 8;
^
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was testing the latest
c-apicommit against Sorbet, and I found a few warnings that need to be addressed:Avoid declaring unused
nodevariables inrbs_node_destroy's templateSuch declarations will fail Sorbet's compiler:
Use
size_tinstead ofintforcapacityinrbs_loc_alloc_childrenThis fixes a warning about comparing
intandsize_tinrbs_loc_alloc_children's assertion.Avoid declaring the
maxvariable that's just used in assertionsWhen the
assertis stripped out, the variable becomes unused and triggers a warning.