This repository has been archived by the owner on Jan 10, 2025. It is now read-only.
Typescript 4.9 #2409
Merged
Typescript 4.9 #2409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BPScott
force-pushed
the
ts4.8
branch
3 times, most recently
from
3e0ddcf to
783a8bd
Compare
|
/snapit |
|
🫰✨ Thanks @BPScott! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected]yarn add [email protected]yarn add [email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected] |
|
/snapit |
|
🫰✨ Thanks @BPScott! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected]yarn add [email protected]yarn add [email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected] |
|
Trying these snapshots out over in https://buildkite.com/shopify/web-ci-builder/builds?branch=quilt-ts49-test. They're failing at the moment, hold off on reviewing till they go green. |
- Update types to account for lib.d.ts changes regarding Navigator and Window. - Propogate generic constraints
|
/snapit |
|
🫰✨ Thanks @BPScott! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add [email protected]yarn add [email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected] |
|
/snapit |
|
🫰✨ Thanks @BPScott! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add [email protected]yarn add [email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected] |
…ed in consuming projects
|
Haha, yes that's now passing in web, with some minor changes. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating to typescript 4.9.2.
In particular I'm excited by the 4.8 update to how file watching works, which should stop VSCode's typescript server thrashing when you switch branches. Also type-check goes from ~15 to ~12 seconds which is always nice.
See https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/
See https://devblogs.microsoft.com/typescript/announcing-typescript-4-9/
Most changes relate to [Generic constraints no longer extending from {}](https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/#unconstrained-generics-no-longer-assignable-to}. The explanation is pretty dense but the fix boils down to: "Add
extends {}if the generic argument can be null/undefined, otherwise addextends objector the the functionally equalextends {[key: string]: unknown}if it's always going to be an object. See microsoft/TypeScript#49489 / microsoft/TypeScript#49119 for more info.For GraphQL stuff we want to mimic
graphql-typed-document-nodeso we useextends {[key: string]: unknown}Other changes are regarding small adjustments to Window and NavigatorConnection.