Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Arel instead of String for AR Enumerator conditionals #456

Merged
merged 5 commits into from
Feb 14, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions lib/job-iteration/active_record_cursor.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,8 @@ def initialize
end
end

def initialize(relation, columns = nil, position = nil)
@columns = if columns
Array(columns)
else
Array(relation.primary_key).map { |pk| "#{relation.table_name}.#{pk}" }
end
def initialize(relation, columns, position = nil)
@columns = columns
self.position = Array.wrap(position)
raise ArgumentError, "Must specify at least one column" if columns.empty?
if relation.joins_values.present? && [email protected]? { |column| column.to_s.include?(".") }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still necessary, now that it's an arel attribute being passed in instead of a string?

Copy link
Contributor Author

@pedropb pedropb May 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic was left untouched because on the presence of join conditions, the ORDER by columns can become ambiguous and fail the queries.
The .all? clause was a constraint to prevent this failure mode.

Also FWIW, the changes in this PR were reverted in #483 (v1.5.1). There's more context about the bug it introduced in #483.

Expand All @@ -34,7 +30,7 @@ def initialize(relation, columns = nil, position = nil)
raise ConditionNotSupportedError
end

@base_relation = relation.reorder(@columns.join(","))
@base_relation = relation.reorder(*@columns)
@reached_end = false
end

Expand All @@ -54,12 +50,10 @@ def position=(position)

def update_from_record(record)
self.position = @columns.map do |column|
method = column.to_s.split(".").last

if ActiveRecord.version >= Gem::Version.new("7.1.0.alpha") && method == "id"
if ActiveRecord.version >= Gem::Version.new("7.1.0.alpha") && column.name == "id"
record.id_value
else
record.send(method.to_sym)
record.send(column.name)
end
end
end
Expand Down Expand Up @@ -89,14 +83,14 @@ def conditions
i = @position.size - 1
column = @columns[i]
conditions = if @columns.size == @position.size
"#{column} > ?"
column.gt(@position[i])
else
"#{column} >= ?"
column.gteq(@position[i])
end
while i > 0
i -= 1
column = @columns[i]
conditions = "#{column} > ? OR (#{column} = ? AND (#{conditions}))"
conditions = column.gt(@position[i]).or(column.eq(@position[i]).and(conditions))
end
ret = @position.reduce([conditions]) { |params, value| params << value << value }
ret.pop
Expand Down
10 changes: 5 additions & 5 deletions lib/job-iteration/active_record_enumerator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ def initialize(relation, columns: nil, batch_size: 100, cursor: nil)
@relation = relation
@batch_size = batch_size
@columns = if columns
Array(columns)
Array(columns).map { |col| relation.arel_table[col.to_sym] }
else
Array(relation.primary_key).map { |pk| "#{relation.table_name}.#{pk}" }
Array(relation.primary_key).map { |pk| relation.arel_table[pk.to_sym] }
end
@cursor = cursor
end
Expand Down Expand Up @@ -45,7 +45,7 @@ def size

def cursor_value(record)
positions = @columns.map do |column|
attribute_name = column.to_s.split(".").last
attribute_name = column.name.to_sym
column_value(record, attribute_name)
end
return positions.first if positions.size == 1
Expand All @@ -58,8 +58,8 @@ def finder_cursor
end

def column_value(record, attribute)
value = record.read_attribute(attribute.to_sym)
case record.class.columns_hash.fetch(attribute).type
value = record.read_attribute(attribute)
case record.class.columns_hash.fetch(attribute.to_s).type
when :datetime
value.strftime(SQL_DATETIME_WITH_NSEC)
else
Expand Down
Loading