Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ConditionNotSupportedError raise #289

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

packrat386
Copy link
Contributor

This constant does not exist in this scope. Running the test in the PR without the associated code change results in: "uninitialized constant JobIteration::ActiveRecordBatchEnumerator::ConditionNotSupportedError"

@packrat386 packrat386 force-pushed the fix_condition_not_supported_raise branch from 9a74518 to 0914072 Compare October 26, 2022 19:35
This constant does not exist in this scope. Running the test in the PR
without the associated code change results in: "uninitialized constant
JobIteration::ActiveRecordBatchEnumerator::ConditionNotSupportedError"
@packrat386
Copy link
Contributor Author

I rebased this with the new rubocop updates.

Copy link
Contributor

@Mangara Mangara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this!

@Mangara Mangara merged commit 5e0147f into Shopify:main Oct 26, 2022
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems November 2, 2022 20:05 Inactive
@lavoiesl lavoiesl mentioned this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants