Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Ruby 2.6 & Rails 5.2 due to EOL #241

Merged
merged 3 commits into from
Jun 29, 2022
Merged

Conversation

sambostock
Copy link
Contributor

This drops support for Ruby 2.6 and Rails 5.2, as they are past their end-of-life dates.

CI is failing the most recent version of rubocop supports Ruby 2.6 and has breaking configuration changes, and while rubocop-shopify's most recent version addresses the breaking changes, it dropped Ruby 2.6 support several versions ago. Rather than work around this, we can simply drop support.

@sambostock sambostock changed the title Drop support for old Ruby/Rails versions Drop support for Ruby 2.6 & Rails 5.2 due to EOL Jun 28, 2022
dev.yml Outdated Show resolved Hide resolved
This is the most recent patch version of the oldest minor version that has not
reached end-of-life.
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@peterzhu2118 peterzhu2118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sambostock sambostock merged commit f91d938 into main Jun 29, 2022
@sambostock sambostock deleted the drop-ruby-2-6 branch June 29, 2022 19:41
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems June 29, 2022 19:44 Inactive
@lavoiesl lavoiesl mentioned this pull request Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants