-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip Oxygen checks when @shopify/remix-oxygen
is not installed
#1137
Conversation
…pify#1137) * Rename config file * Extract assertOxygenChecks * Assert Oxygen checks only in build and dev commands * Only assert Oxygen checks when remix-oxygen is installed * Remove type fixes for old versions of Remix * Changesets
@frandiox Hey. I'm updating our template and it looks like these checks are still being triggered when |
Hi! Forgot to reply earlier today but here's a PR that removes Edit: @ascorbic You can try with ![]() |
Related to #1122
This PR skips Oxygen requirements we had for the config when not deploying to Oxygen.
I've also renamed
config.ts
toremix-config.ts
to make it more obvious since we have another file calledshopify-config.ts
.