Remove Apollo tracing spec support #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalkinshaw
commented
Jul 15, 2024
| @time_since_offset = time_since_offset | ||
| @result = result | ||
| end | ||
| [result, duration] |
There was a problem hiding this comment.
I could keep a simplified TimedResult which is better for readability, but figured the array/tuple is simpler
Apollo's tracing [spec](https://github.com/apollographql/apollo-tracing) has long been deprecated. This removes support for `offset` timestamps which were only needed for Apollo tracing. Dropping these offsets simplifies our code and lets us store an array of resolver timing duration timestamps instead of hashes as well.
swalkinshaw
force-pushed
the
remove-apollo-tracing-spec-support
branch
from
9c075ea to
8f96cf2
Compare
guialbuk
approved these changes
Jul 15, 2024
gmac
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apollo's tracing spec has long been deprecated. This removes support for
offsettimestamps which were only needed for Apollo tracing.Dropping these offsets simplifies our code and lets us store an array of resolver timing duration timestamps instead of hashes as well.
This is a breaking change. However, at least internally at Shopify, we never consumed these offsets.
Note: I'm extracting a few cleanups/changes from #81 to ship them separately.