Reduce TimedResult objects #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently graphql-metrics creates a new `TimedResult` object for every single traced field. This can add a lot of object allocations for large documents which can put more pressure on garbage collection. Since `trace_field` is a hot path, this replaces the `GraphQL::Metrics.time` usage with manual time calculations. The other usages are left since they only occur once per operation execution.
|
CI was broken due to a deprecated action so I re-did the workflow 🚀 |
swalkinshaw
commented
Feb 10, 2023
| @@ -93,10 +93,7 @@ def capture_multiplex_start_time | |||
| end | |||
|
|
|||
| def capture_lexing_time | |||
| # GraphQL::Query#result fires `lex` before the `execute_multiplex` event, so sometimes | |||
| # `pre_context.multiplex_start_time_monotonic` isn't set. | |||
| lexing_offset_time = pre_context.multiplex_start_time_monotonic || GraphQL::Metrics.current_time_monotonic | |||
There was a problem hiding this comment.
@chrisbutcher this didn't appear to be used at all? The offset is only needed if time_since_offset is used, but it's not in either of these two places (only duration and start_time are)
.github/workflows/ruby.yml
Outdated
| fail-fast: false | ||
| matrix: | ||
| os: [ubuntu-latest] | ||
| ruby: ['2.7', '3.0', '3.1'] |
There was a problem hiding this comment.
Did you forget Ruby 3.2 or is there a reason we don't yet test or support it?
There was a problem hiding this comment.
Just forgot, added it thanks
swalkinshaw
force-pushed
the
reduce-timed-result-objects
branch
from
ab549ae to
a008d72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently graphql-metrics creates a new
TimedResultobject for every single traced field. This can add a lot of object allocations for large documents which can put more pressure on garbage collection.Since
trace_fieldis a hot path, this replaces theGraphQL::Metrics.timeusage with manual time calculations. The other usages are left since they only occur once per operation execution.