Add a custom wrapper around #perform #160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR This PR adds a wrapper method around the
#perform
method. This allows us to wrap the#perform
method within code blocks that would help with measuring the performance in terms of time taken or the number of sql queries executed or anything elseToday, we have to override the
#resolve
method as demonstrated by the example below.With the proposed changes, the
#resolve
method does not need to be overridden and a system can call multiple wrappers if required.How did this come up?
Today we override the
#resolve
method. But we were looking to add tracing as well. While the tracing can be added within the#resolve
method, it'd be nicer to add a shared implementation for this gem within Opentelemetry (tracking issue).This is a non breaking change and should not cause any issues. This PR also releases v0.5.3