Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ActiveStorageLoader example #159

Conversation

letiesperon
Copy link
Contributor

@letiesperon letiesperon commented Apr 7, 2023

Hi guys!
Unless I'm missing something (which I might be) this comment is inconsistent with the class name

@swalkinshaw
Copy link
Contributor

@letiesperon thanks for the fix. You'll need to Sign the CLA to have your PR reviewed and merged.

@letiesperon letiesperon force-pushed the chore/fix-active-storage-loader-example branch from 3f72f1e to 4a89a9d Compare April 10, 2023 19:21
@letiesperon
Copy link
Contributor Author

@swalkinshaw thanks! done

@swalkinshaw swalkinshaw merged commit e476f7c into Shopify:master Apr 11, 2023
@shopify-shipit shopify-shipit bot temporarily deployed to rubygems April 11, 2023 19:13 Inactive
@letiesperon letiesperon deleted the chore/fix-active-storage-loader-example branch April 11, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants