This repository has been archived by the owner on Jun 13, 2018. It is now read-only.
Add AustraliaPost Carrier #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @arkes! Sorry for the delayed response. This looks super great. Thanks for your contribution. @jonathankwok when you have a minute, can I get a second set of 👀 ? |
| rescue ActiveUtils::ResponseError, ActiveShipping::ResponseError => e | ||
| data = JSON.parse(e.response.body) | ||
|
|
||
| RateResponse.new(false, data['error']['errorMessage'], data) |
There was a problem hiding this comment.
There is an assumption here that a parsed error body will always have a error: key. This can raise a nil error.
|
This is very clean, well-done, and thorough! 👏 |
- Add URI - fix parse body with error message
| endpoint = domestic_destination? ? @endpoints[:domestic] : @endpoints[:international] | ||
| params = domestic_destination? ? domestic_params : international_params | ||
|
|
||
| URI::HTTPS.build(host: HOST, path: endpoint, query: params.to_query).to_s |
|
Nice. Happy with it @arkes? Good to merge? |
|
Hey @kmcphillips, yes all good thanks! |
|
Released in 1.7.3 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support currently: