Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support windows #7

Merged
merged 1 commit into from
Jan 19, 2025
Merged

chore: support windows #7

merged 1 commit into from
Jan 19, 2025

Conversation

simoneb
Copy link
Contributor

@simoneb simoneb commented Jan 13, 2025

We're using this in https://github.com/nearform/fast-jwt and the logic to locate the runner module doesn't work on Windows.

In order to fix that, besides fixing the logic itself, I had to do a few more changes:

  1. use cross-env to set env vars during test on Windows
  2. update some swc dependencies because they would no longer resolve with newer versions of Node
  3. updated the ci workflow to run the build across multiple versions of OS and Node. Note that I had to do a specific exclusion for the combination windows/Node 18 because the node:test test location algorithm has been changed and it wouldn't locate tests on Windows, on that specific version of Node. I thought this wouldn't be a big deal
  4. minor changes here and there

I would appreciate it if you could review this, which only contains a minor functional change, and release a new version that we can consume in our downstream packages.

@@ -23,6 +28,7 @@ jobs:
- name: Install dependencies
run: pnpm install --shamefully-hoist
- name: Run Tests
if: matrix.os != 'windows-latest' && matrix.node-version != '20.18.0'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests won't run on Windows just for Node 20.18.0. They run for newer versions so I thought it wouldn't be a big deal. Fixing this would not be easy otherwise

src/models.ts Show resolved Hide resolved
@ShogunPanda ShogunPanda merged commit ad12fbd into ShogunPanda:main Jan 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants