Skip to content

Commit

Permalink
chore: fix this.rootSpan undefined bug in PageLoadInstrumentation (ap…
Browse files Browse the repository at this point in the history
  • Loading branch information
dvj1988 authored Sep 23, 2024
1 parent e798ec6 commit 7685c85
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions app/client/src/UITelemetry/PageLoadInstrumentation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,15 +41,12 @@ export class PageLoadInstrumentation extends InstrumentationBase {
this.ignoreResourceUrls = ignoreResourceUrls;
// Start the root span for the page load
this.rootSpan = startRootSpan("PAGE_LOAD", {}, 0);
}

init() {
// init method is present in the base class and needs to be implemented
// This is method is never called by the OpenTelemetry SDK
// Leaving it empty as it is done by other OpenTelemetry instrumentation classes
// Initialize the instrumentation after starting the root span
this.init();
}

enable(): void {
init() {
// Register connection change listener
this.addConnectionAttributes();

Expand All @@ -71,6 +68,11 @@ export class PageLoadInstrumentation extends InstrumentationBase {
}
}

enable() {
// enable method is present in the base class and needs to be implemented
// Leaving it empty as there is no need to do anything here
}

private addDeviceAttributes() {
this.rootSpan.setAttributes({
deviceMemory: (navigator as TNavigator).deviceMemory,
Expand Down

0 comments on commit 7685c85

Please sign in to comment.