Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating EvtCalc interface to work with any N-body decay #581

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

mferril
Copy link
Collaborator

@mferril mferril commented Dec 17, 2024

The interface has been updated to work with any LLP n-body final state, following the latest developments in EvtCalc (#536 , #538 , #540 ).

FYI: @olantwin @maksymovchynnikov

macro/convertEvtCalc.py Outdated Show resolved Hide resolved
Copy link
Contributor

@olantwin olantwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formatting issues, otherwise this looks good to be merged.

Could you link any issues that would be closed by this?

macro/convertEvtCalc.py Outdated Show resolved Hide resolved
macro/convertEvtCalc.py Outdated Show resolved Hide resolved
macro/convertEvtCalc.py Outdated Show resolved Hide resolved
macro/convertEvtCalc.py Outdated Show resolved Hide resolved
macro/convertEvtCalc.py Outdated Show resolved Hide resolved
macro/convertEvtCalc.py Outdated Show resolved Hide resolved
@olantwin
Copy link
Contributor

A very short entry in the change log would also be appreciated!

@mferril
Copy link
Collaborator Author

mferril commented Dec 18, 2024

Could you link any issues that would be closed by this?

@olantwin Please see the description. Should it be linked somewhere else?

@mferril
Copy link
Collaborator Author

mferril commented Dec 18, 2024

A very short entry in the change log would also be appreciated!

@olantwin added

@mferril
Copy link
Collaborator Author

mferril commented Dec 18, 2024

@olantwin Everything is ready from my side, and the pull request is ready to be merged.

macro/convertEvtCalc.py Outdated Show resolved Hide resolved
@olantwin
Copy link
Contributor

A very short entry in the change log would also be appreciated!

@olantwin added

Did you commit it?

@mferril
Copy link
Collaborator Author

mferril commented Dec 18, 2024

A very short entry in the change log would also be appreciated!

@olantwin added

Did you commit it?

Yes, it should be available now.

@olantwin
Copy link
Contributor

It's not.

@mferril
Copy link
Collaborator Author

mferril commented Dec 18, 2024

It's not.

You should be getting a pull request, and I don't understand why it is not visible. This is the second time I submit it.

@olantwin
Copy link
Contributor

It's not.

You should be getting a pull request, and I don't understand why it is not visible. This is the second time I submit it.

Ah, now it finally appeared. By why don't you just add it to this PR? Ideally we'd squash all these commits, at least the fixups.

@olantwin olantwin merged commit 790161e into ShipSoft:master Dec 18, 2024
1 of 2 checks passed
@mferril mferril deleted the EvtCalc_interface branch December 20, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants