Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SST boxes medium will now follow DecayVolumeMedium #575

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

olantwin
Copy link
Contributor

@olantwin olantwin commented Dec 5, 2024

@evanherwijnen noticed that the boxes containing the stations were still vaccums. This change should now make the medium follow the one used for the decay volume.

@olantwin olantwin requested review from wcmartylee and a team as code owners December 5, 2024 08:55
@wcmartylee
Copy link
Contributor

@evanherwijnen noticed that the boxes containing the stations were still vaccums. This change should now make the medium follow the one used for the decay volume.

Hi Oliver, thanks for this find! On a second thought, the stations are actually in air with the helium option.

@olantwin
Copy link
Contributor Author

olantwin commented Dec 5, 2024

Ok, so then is should be vacuum for the vacuum option and air otherwise?

@wcmartylee
Copy link
Contributor

Ok, so then is should be vacuum for the vacuum option and air otherwise?

Yes.

@olantwin
Copy link
Contributor Author

olantwin commented Dec 5, 2024

Ok, now it should be the desired behaviour. Please test.

@evanherwijnen
Copy link
Contributor

evanherwijnen commented Dec 5, 2024 via email

@wcmartylee
Copy link
Contributor

Only sometimes these errors would appear by running Reco:
shipDigiReco::findVetoHitOnTrack extrapolation did not worked
shipVertex: extrapolation did not work

Might not be due to this change, but I’m not sure.

@olantwin
Copy link
Contributor Author

olantwin commented Dec 9, 2024

That is unrelated, or at least it already occurred occasionally before.
Then could you please approve?

@olantwin olantwin merged commit 0896c8a into master Dec 9, 2024
1 of 2 checks passed
@olantwin olantwin deleted the sst_air branch December 9, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants