Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K_convention to represent cheb polynomial order #64

Merged
merged 5 commits into from
Feb 9, 2025
Merged

Conversation

SherylHYX
Copy link
Owner

Due to popular request to match the code convention to the K parameter in papers, I have updated K parameter in MagNet and MSGNN codes to represent the Cheb polynomial order instead of filter size, which is filter size minus 1.

Copy link

codecov bot commented Feb 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.59%. Comparing base (10f54d8) to head (86f9f33).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files          77       77           
  Lines        3728     3728           
=======================================
  Hits         3713     3713           
  Misses         15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SherylHYX SherylHYX merged commit 029ed9f into main Feb 9, 2025
4 checks passed
@SherylHYX SherylHYX deleted the K_convention branch February 9, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant