[fix][client] Make protobuf-java dependency optional in java client libraries #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache#23469
Motivation
In the Pulsar Java client libraries, the
protobuf-java
library is only used inProtobufSchema
, making it suitable as an optional dependency. However, it is mistakenly included in thepulsar-client-admin
andpulsar-client-all
shaded jar and declared as required dependency ofpulsar-client
,pulsar-client-original
andpulsar-client-admin-original
, as noted by @merlimat in this discussion.PR apache#23468 moved
protobuf-java
from a shaded JAR to a declared dependency in thepom.xml
, which helped avoid conflicts betweenprotobuf-java
and application dependencies. Since users only needprotobuf-java
when usingProtobufSchema
, it makes sense to declare it as an optional dependency. This change reduces the number of dependencies in the Pulsar client libraries.Verifying this change
protobuf-java
dependency is not included in the installedpom.xml
files.Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: