Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibJS: Add %TypedArray%.prototype.toReversed #14445

Merged
merged 2 commits into from
Jul 2, 2022
Merged

LibJS: Add %TypedArray%.prototype.toReversed #14445

merged 2 commits into from
Jul 2, 2022
+108 −1

Conversation

beesaferoot
Copy link
Contributor

No description provided.

linusg
linusg reviewed Jun 30, 2022
View reviewed changes
Copy link
Member

@linusg linusg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, mostly LGTM! First commit contains the tests that should probably go into the second :)

Userland/Libraries/LibJS/Runtime/TypedArrayPrototype.cpp Outdated Show resolved Hide resolved
Userland/Libraries/LibJS/Runtime/TypedArrayPrototype.cpp Outdated Show resolved Hide resolved
Userland/Libraries/LibJS/Runtime/TypedArrayPrototype.cpp Show resolved Hide resolved
Userland/Libraries/LibJS/Runtime/TypedArrayPrototype.cpp Outdated Show resolved Hide resolved
Userland/Libraries/LibJS/Runtime/TypedArrayPrototype.cpp Show resolved Hide resolved
Userland/Libraries/LibJS/Runtime/TypedArrayPrototype.h Show resolved Hide resolved
@beesaferoot beesaferoot force-pushed the typed-array-update branch 2 times, most recently from 0f6dd38 to dc8a5ea Compare July 2, 2022 16:16
linusg
linusg reviewed Jul 2, 2022
View reviewed changes
Userland/Libraries/LibJS/Runtime/TypedArrayPrototype.cpp Outdated
// 6. Repeat, while k < length
for (size_t k = 0; k < length; k++) {
// a. Let from be ! ToString(𝔽(length - k - 1)).
// Let Pk be ! ToString(𝔽(k)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing b.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added. :)

@beesaferoot beesaferoot force-pushed the typed-array-update branch from dc8a5ea to dee66f3 Compare July 2, 2022 19:47
@linusg linusg force-pushed the typed-array-update branch from dee66f3 to c5812e4 Compare July 2, 2022 23:12
@linusg linusg merged commit 5f726ac into SerenityOS:master Jul 2, 2022
@linusg linusg mentioned this pull request Dec 7, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linusg linusg linusg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beesaferoot @linusg