Skip to content

Still something wrong with adding/removing neighbors #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chrisoro opened this issue Jan 13, 2018 · 6 comments
Closed

Still something wrong with adding/removing neighbors #50

chrisoro opened this issue Jan 13, 2018 · 6 comments
Assignees
@romansemko

Comments

@chrisoro
Copy link

chrisoro commented Jan 13, 2018 •
edited
Loading

Hey @romansemko, last time I found out that static neighbors were removed in like 0.3.1 or so.. Since then I have been monitoring the neighbor count closely. I observed the same two problems on my 3 nodes:

Expected behaviour

  1. Amount of added neighbors should not violate the settings
  2. When closing nelson it should remove all previously added neigbhbors

Actual behaviour

  1. Having 2 static neighbors and setting nelson to 4 / 3 (in/out) there are sometimes up to 13 neighbors reported by iri
  2. I often end up with 3 sometimes up to 5 neighbors after closing nelson. Substracting my 2 static neighbors, that leaves me with 1 to 3 added neighbors (by nelson) that it didn't remove properly on exit

Steps to reproduce

  • Start iri and nelson
  • Wait until sync
  • Look at neighbor count in iri (see that it's not following nelsons config)
  • Close nelson
  • Look at neighbor count in iri (see that you have more neighbors than before starting nelson)

Basic Info

  • Operating System: Ubuntu 17.10 (x64)
  • Node (npm) Version: node: 8.9.4 (npm: 5.6)
  • IRI Version: 1.4.1.6
  • Nelson version: 0.3.16
@chrisoro
Copy link
Author

Woke up today with one node having 20(!!!) active neighbors. After stopping nelson it still had 10. I think it sometimes 'forgets' about the added neighbors (or the remove failed but nelson thinks it succeeded) and keeps on going.

@H3npi
Copy link

H3npi commented Jan 14, 2018

somehow i can't reproduce this. Do you mean aktive neighbors or total neighbors?
where do you get the neighbor count from?

@chrisoro
Copy link
Author

Calling iri api with getNeighbors

@romansemko romansemko self-assigned this Jan 23, 2018
romansemko added a commit that referenced this issue Jan 24, 2018
@romansemko
Multiple bugfixes, package upgrades and tests
e31b944 
### Added
- Additional entry nodes
- Possible fix for #45 ECONNRESET error
- Interval-compression of the neighbors database
- IRI cleanup of neighbors. Possible fix for #50
- Additional Peer and PeerList tests. Fixes #43
- Guard tests
- Basic node tests
- Node network integration tests
- Basic node network simulation package
- Parts of the node simulation package for integration tests

### Changed
- Upgraded minimal node version to 8.9.4
- Cleanup nelson on uncaught exception. Possible fix for #50
- Upgrades WebSockets to 4.0.0. Possible fix for #45
- Fixed docker to copy faster, ignoring unneeded files
- Made docker run the tests while building
@romansemko
Copy link

Please try version 0.3.21. Restart IRI before starting the new Nelson version

Please re-open the ticket or create a new one if you see this problem persist.

@chrisoro
Copy link
Author

chrisoro commented Feb 4, 2018

Observed again right now on 3 different nodes. Stopped nelson because I wanted to update to 0.4 and it didn't remove all neighnors (3, 1, 1 left)

@romansemko
Copy link

Please stop IRI and nelson, install 0.4.0 and restart IRI/Nelson. 0.4.0 fixed another neighbours leak to IRI. This might have been in your case..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romansemko romansemko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@H3npi @romansemko @chrisoro