Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump dependencies to allow React 17 in peerDependencies #4138

Merged
merged 1 commit into from
Jan 13, 2021
Merged

chore: bump dependencies to allow React 17 in peerDependencies #4138

merged 1 commit into from
Jan 13, 2021

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Jan 13, 2021 •
edited
Loading

Related to #4129.

Bumps all React dependencies to have React 17 as an allowed in peerDependencies range. Now all deps require React ^16.8 || ^17:

@fluentui/[email protected]" has unmet peer dependency "react@^16.8.0 || ^17".
@fluentui/[email protected]" has unmet peer dependency "react-dom@^16.8.0 || ^17".
@fluentui/[email protected]" has unmet peer dependency "react@^16.8.0 || ^17".
@fluentui/[email protected]" has unmet peer dependency "react-dom@^16.8.0 || ^17".
[email protected]" has unmet peer dependency "react@^16.8.0 || ^17".
@semantic-ui-react/[email protected]" has unmet peer dependency "react@^16.0.0 || ^17.0.0".
@semantic-ui-react/[email protected]" has unmet peer dependency "react-dom@^16.0.0 || ^17.0.0".
[email protected]" has unmet peer dependency "react@^16.8.0 || ^17.0.0".
[email protected]" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0".

With installed [email protected] and [email protected] warnings are gone.

@github-actions
Copy link

size-limit report

Path Size
bundle-size/dist/Button.size.js 58.58 KB (+0.2% 🔺)
bundle-size/dist/Icon.size.js 25.06 KB (0%)
bundle-size/dist/Image.size.js 53.76 KB (+0.22% 🔺)
bundle-size/dist/Modal.size.js 68.66 KB (+0.17% 🔺)
bundle-size/dist/Portal.size.js 40.46 KB (+0.29% 🔺)

@layershifter layershifter merged commit 66fbd8f into master Jan 13, 2021
@layershifter layershifter deleted the chore/bump-deps branch January 13, 2021 14:31
@layershifter layershifter mentioned this pull request Jan 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Internal 🏠
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@layershifter