Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict type dropdown #2839

Closed
wants to merge 4 commits into from
Closed

Conversation

evollu
Copy link
Contributor

@evollu evollu commented May 25, 2018

add StrictDropdownProps based on discussion on #2836
somehow precommit step is reformatting the whole file

more PRs coming

@welcome
Copy link

welcome bot commented May 25, 2018

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@stale
Copy link

stale bot commented Aug 23, 2018

There has been no activity in this thread for 90 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 90 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

@levithomason
Copy link
Member

Sorry for the huge delay here! I think this change looks good. If we start this work, we'll need to complete it for all components. That is a large effort. Is this something you'd like to start up?

@evollu evollu closed this Aug 26, 2018
@evollu evollu deleted the strict-type-dropdown branch August 26, 2018 05:26
@evollu
Copy link
Contributor Author

evollu commented Aug 26, 2018

the PR is too old, I open a new one with all props updated @levithomason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants