-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java][dotnet][js] Fix failing BiDi related tests #15296
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Motivation and Context
Prepping for the release
Types of changes
Checklist
PR Type
Bug fix, Tests
Description
Fixed BiDi-related test failures across Java, .NET, and JavaScript.
Updated
EvaluateParameters
to removeuserActivation
in Java and .NET tests.Adjusted JavaScript test to ignore specific browsers for fragment navigation.
Improved test consistency and alignment with specifications.
Changes walkthrough 📝
CallFunctionParameterTest.java
Adjusted `EvaluateParameters` usage in Java tests
java/test/org/openqa/selenium/bidi/script/CallFunctionParameterTest.java
userActivation
parameter inEvaluateParameters
.EvaluateParametersTest.java
Simplified script evaluation in Java tests
java/test/org/openqa/selenium/bidi/script/EvaluateParametersTest.java
userActivation
parameter inEvaluateParameters
.CallFunctionParameterTest.cs
Updated BiDi script evaluation in .NET tests
dotnet/test/common/BiDi/Script/CallFunctionParameterTest.cs
UserActivation
parameter inEvaluateAsync
.EvaluateParametersTest.cs
Enhanced script evaluation tests in .NET
dotnet/test/common/BiDi/Script/EvaluateParametersTest.cs
UserActivation
parameter inEvaluateAsync
.browsingcontext_inspector_test.js
Adjusted fragment navigation test in JavaScript
javascript/node/selenium-webdriver/test/bidi/browsingcontext_inspector_test.js