[java] Add nullness for enums (#15105)

Co-authored-by: Viet Nguyen Duc <[email protected]>
SeleniumHQ · Jan 20, 2025 · 3c16d81 · 3c16d81
1 parent 4461033
commit 3c16d81
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/java/src/org/openqa/selenium/PageLoadStrategy.java b/java/src/org/openqa/selenium/PageLoadStrategy.java
@@ -17,6 +17,10 @@
 
 package org.openqa.selenium;
 
+import org.jspecify.annotations.NullMarked;
+import org.jspecify.annotations.Nullable;
+
+@NullMarked
 public enum PageLoadStrategy {
   NONE("none"),
   EAGER("eager"),
@@ -33,7 +37,7 @@ public String toString() {
     return String.valueOf(text);
   }
 
-  public static PageLoadStrategy fromString(String text) {
+  public static @Nullable PageLoadStrategy fromString(@Nullable String text) {
     if (text != null) {
       for (PageLoadStrategy b : PageLoadStrategy.values()) {
         if (text.equalsIgnoreCase(b.text)) {

diff --git a/java/src/org/openqa/selenium/UnexpectedAlertBehaviour.java b/java/src/org/openqa/selenium/UnexpectedAlertBehaviour.java
@@ -17,6 +17,10 @@
 
 package org.openqa.selenium;
 
+import org.jspecify.annotations.NullMarked;
+import org.jspecify.annotations.Nullable;
+
+@NullMarked
 public enum UnexpectedAlertBehaviour {
   ACCEPT("accept"),
   DISMISS("dismiss"),
@@ -35,7 +39,7 @@ public String toString() {
     return String.valueOf(text);
   }
 
-  public static UnexpectedAlertBehaviour fromString(String text) {
+  public static @Nullable UnexpectedAlertBehaviour fromString(@Nullable String text) {
     if (text != null) {
       for (UnexpectedAlertBehaviour b : UnexpectedAlertBehaviour.values()) {
         if (text.equalsIgnoreCase(b.text)) {

diff --git a/java/src/org/openqa/selenium/WindowType.java b/java/src/org/openqa/selenium/WindowType.java
@@ -17,7 +17,11 @@
 
 package org.openqa.selenium;
 
+import org.jspecify.annotations.NullMarked;
+import org.jspecify.annotations.Nullable;
+
 /** Represents the type of new browser window that may be created. */
+@NullMarked
 public enum WindowType {
   WINDOW("window"),
   TAB("tab"),
@@ -34,7 +38,7 @@ public String toString() {
     return String.valueOf(text);
   }
 
-  public static WindowType fromString(String text) {
+  public static @Nullable WindowType fromString(@Nullable String text) {
     if (text != null) {
       for (WindowType b : WindowType.values()) {
         if (text.equalsIgnoreCase(b.text)) {