Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Fix CVEs in dependencies #2675

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Docker: Fix CVEs in dependencies #2675

merged 1 commit into from
Feb 24, 2025

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Feb 24, 2025

User description

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Bug fix, Enhancement


Description

  • Updated dependencies to address CVEs and improve security.

  • Adjusted workflows to optimize parallel execution and directory creation.

  • Enhanced backward compatibility scripts with additional Python script execution.

  • Updated browser matrix with new Firefox version details.


Changes walkthrough 📝

Relevant files
Enhancement
bootstrap.sh
Enhance backward compatibility script execution                   

tests/build-backward-compatible/bootstrap.sh

  • Added execution of fetch_version.py script.
  • Improved backward compatibility script flow.
  • +2/-0     
    chart_setup_env.sh
    Update envsubst version and download source                           

    tests/charts/make/chart_setup_env.sh

  • Updated ENVSUBST_VERSION to a patched version.
  • Changed envsubst download URL to a new repository.
  • +2/-2     
    release-chrome-versions.yml
    Optimize Chrome release workflow                                                 

    .github/workflows/release-chrome-versions.yml

  • Limited parallel execution with max-parallel: 1.
  • Removed redundant mkdir step for CHANGELOG directory.
  • +1/-2     
    release-edge-versions.yml
    Optimize Edge release workflow                                                     

    .github/workflows/release-edge-versions.yml

  • Limited parallel execution with max-parallel: 1.
  • Adjusted CHANGELOG directory creation step.
  • +3/-2     
    release-firefox-versions.yml
    Optimize Firefox release workflow                                               

    .github/workflows/release-firefox-versions.yml

  • Limited parallel execution with max-parallel: 1.
  • Adjusted CHANGELOG directory creation step.
  • +3/-2     
    browser-matrix.yml
    Update Firefox version in browser matrix                                 

    tests/build-backward-compatible/browser-matrix.yml

  • Updated Firefox version for browser 135.
  • Added corresponding download URL for the updated version.
  • +1/-1     
    Bug fix
    Dockerfile
    Update dependencies and classpath in Dockerfile                   

    Base/Dockerfile

  • Updated GRPC_VERSION and NETTY_VERSION to newer versions.
  • Added new Netty dependencies to the classpath.
  • Updated ENVSUBST_VERSION and its download URL.
  • +6/-4     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Signed-off-by: Viet Nguyen Duc <[email protected]>
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Version Compatibility

    The updated Netty and gRPC versions should be validated for compatibility with the rest of the system dependencies, particularly with OpenTelemetry version 1.46.0

    ARG GRPC_VERSION=1.70.0
    ARG NETTY_VERSION=4.1.118.Final
    Version Mismatch

    Firefox version 135.0.1 is specified but the download URL still points to version 135.0a1 which is an alpha version. This mismatch should be verified.

    FIREFOX_VERSION: 135.0.1
    FIREFOX_DOWNLOAD_URL: https://download-installer.cdn.mozilla.net/pub/firefox/nightly/2025/01/2025-01-06-09-47-46-mozilla-central/firefox-135.0a1.en-US.linux-aarch64.deb

    Copy link

    PR Code Suggestions ✨

    Copy link

    qodo-merge-pro bot commented Feb 24, 2025

    CI Feedback 🧐

    (Feedback updated until commit 0b5f419)

    A test triggered by this PR failed. Here is an AI-generated analysis of the failure:

    Action: Rerun workflow when failure

    Failed stage: Authenticate GitHub CLI for PR [❌]

    Failure summary:

    The action failed because the GitHub authentication token lacks the required 'read:org' permission
    scope. Specifically:

  • The workflow attempted to authenticate using gh auth login --with-token
  • The provided token (GH_CLI_TOKEN_PR) was invalid due to missing the 'read:org' scope
  • This resulted in an authentication error and the workflow failed with exit code 1

  • Relevant error logs:
    1:  ##[group]Operating System
    2:  Ubuntu
    ...
    
    28:  SecurityEvents: write
    29:  Statuses: write
    30:  ##[endgroup]
    31:  Secret source: Actions
    32:  Prepare workflow directory
    33:  Prepare all required actions
    34:  Getting action download info
    35:  Download action repository 'actions/checkout@main' (SHA:85e6279cec87321a52edac9c87bce653a07cf6c2)
    36:  Complete job name: Rerun workflow when failure
    ...
    
    48:  show-progress: true
    49:  lfs: false
    50:  submodules: false
    51:  set-safe-directory: true
    52:  env:
    53:  GH_CLI_TOKEN: ***
    54:  GH_CLI_TOKEN_PR: ***
    55:  RUN_ID: 13492032611
    56:  RERUN_FAILED_ONLY: true
    ...
    
    119:  ##[group]Run sudo apt update
    120:  �[36;1msudo apt update�[0m
    121:  �[36;1msudo apt install gh�[0m
    122:  shell: /usr/bin/bash -e {0}
    123:  env:
    124:  GH_CLI_TOKEN: ***
    125:  GH_CLI_TOKEN_PR: ***
    126:  RUN_ID: 13492032611
    127:  RERUN_FAILED_ONLY: true
    ...
    
    173:  0 upgraded, 0 newly installed, 0 to remove and 42 not upgraded.
    174:  ##[group]Run echo "$GH_CLI_TOKEN_PR" | gh auth login --with-token
    175:  �[36;1mecho "$GH_CLI_TOKEN_PR" | gh auth login --with-token�[0m
    176:  shell: /usr/bin/bash -e {0}
    177:  env:
    178:  GH_CLI_TOKEN: ***
    179:  GH_CLI_TOKEN_PR: ***
    180:  RUN_ID: 13492032611
    181:  RERUN_FAILED_ONLY: true
    182:  RUN_ATTEMPT: 1
    183:  ##[endgroup]
    184:  error validating token: missing required scope 'read:org'
    185:  ##[error]Process completed with exit code 1.
    

    @VietND96 VietND96 merged commit 68cfb93 into trunk Feb 24, 2025
    27 checks passed
    @VietND96 VietND96 deleted the fix-cve branch February 24, 2025 09:28
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant