Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Selenium Grid 4.29.0 #2667

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Update Selenium Grid 4.29.0 #2667

merged 2 commits into from
Feb 21, 2025

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Feb 21, 2025

User description

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

Enhancement


Description

  • Updated Selenium Grid version to 4.29.0 in the Makefile.

  • Adjusted related version variables for consistency with the new release.


Changes walkthrough 📝

Relevant files
Enhancement
Makefile
Update Selenium Grid version variables in Makefile             

Makefile

  • Updated BASE_RELEASE to selenium-4.29.0.
  • Updated BASE_VERSION and BINDING_VERSION to 4.29.0.
  • Updated BASE_VERSION_NIGHTLY to 4.30.0-SNAPSHOT.
  • Updated VERSION and MVN_SELENIUM_VERSION to 4.29.0.
  • +6/-6     

    Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Signed-off-by: Viet Nguyen Duc <[email protected]>
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No major issues detected

    Copy link

    qodo-merge-pro bot commented Feb 21, 2025

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @VietND96 VietND96 merged commit bcbb628 into trunk Feb 21, 2025
    27 checks passed
    @VietND96 VietND96 deleted the 4.29.0 branch February 21, 2025 05:38
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant