Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Try runner Ubuntu 24.04 #2560

Merged
merged 1 commit into from
Jan 6, 2025
Merged

[ci] Try runner Ubuntu 24.04 #2560

merged 1 commit into from
Jan 6, 2025

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Jan 6, 2025

User description

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

In few workflows can see the message
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
To make workflow get ready with ubuntu-24.04, switch to it earlier for checking.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PR Type

enhancement, configuration changes


Description

  • Updated GitHub Actions workflows to use ubuntu-24.04 runner.

  • Replaced ubuntu-latest with ubuntu-24.04 across multiple workflows.

  • Ensured compatibility with the new runner version.

  • Improved CI/CD pipeline consistency and future-proofing.


Changes walkthrough 📝

Relevant files
Configuration changes
11 files
build-test.yml
Updated runner to `ubuntu-24.04` in build-test workflow   
+1/-1     
docker-test.yml
Updated runner to `ubuntu-24.04` in docker-test workflow 
+1/-1     
helm-chart-release.yml
Updated runner to `ubuntu-24.04` in helm-chart-release workflow
+1/-1     
helm-chart-test.yml
Updated runner to `ubuntu-24.04` in helm-chart-test workflow
+1/-1     
k8s-scaling-test.yml
Updated runner to `ubuntu-24.04` in k8s-scaling-test workflow
+3/-3     
label-commenter.yml
Updated runner to `ubuntu-24.04` in label-commenter workflow
+1/-1     
lock.yml
Updated runner to `ubuntu-24.04` in lock workflow               
+1/-1     
rerun-failed.yml
Updated runner to `ubuntu-24.04` in rerun-failed workflow
+1/-1     
scan-dockerfile.yml
Updated runner to `ubuntu-24.04` in scan-dockerfile workflow
+1/-1     
update-chart-readme.yml
Updated runner to `ubuntu-24.04` in update-chart-readme workflow
+1/-1     
update-dev-beta-browser-images.yml
Updated runner to ubuntu-24.04 in update-dev-beta-browser-images
workflow
+2/-2     

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

Copy link

qodo-merge-pro bot commented Jan 6, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

Copy link

qodo-merge-pro bot commented Jan 6, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Score
Possible issue
Use a stable and officially supported Ubuntu runner version instead of a beta release to ensure workflow reliability

Ubuntu 24.04 is currently in beta and not yet officially supported by GitHub
Actions. Consider using a stable version like 'ubuntu-22.04' until 24.04 is
officially released and supported to ensure workflow reliability.

.github/workflows/build-test.yml [68]

-runs-on: ubuntu-24.04
+runs-on: ubuntu-22.04
  • Apply this suggestion
Suggestion importance[1-10]: 9

Why: Using a beta version of Ubuntu (24.04) in production workflows could lead to stability issues and unexpected failures. Switching to the stable ubuntu-22.04 would ensure more reliable CI/CD execution.

9

Copy link

qodo-merge-pro bot commented Jan 6, 2025

CI Failure Feedback 🧐

(Checks updated until commit c5bdc16)

Action: Rerun workflow when failure

Failed stage: Authenticate GitHub CLI for PR [❌]

Failure summary:

The action failed because the GitHub authentication token lacks the required 'read:org' permission
scope. The error occurred during the gh auth login command where the provided token
(GH_CLI_TOKEN_PR) was found to be missing this necessary scope.

Relevant error logs:
1:  ##[group]Operating System
2:  Ubuntu
...

28:  SecurityEvents: write
29:  Statuses: write
30:  ##[endgroup]
31:  Secret source: Actions
32:  Prepare workflow directory
33:  Prepare all required actions
34:  Getting action download info
35:  Download action repository 'actions/checkout@main' (SHA:cbb722410c2e876e24abbe8de2cc27693e501dcb)
36:  Complete job name: Rerun workflow when failure
...

48:  show-progress: true
49:  lfs: false
50:  submodules: false
51:  set-safe-directory: true
52:  env:
53:  GH_CLI_TOKEN: ***
54:  GH_CLI_TOKEN_PR: ***
55:  RUN_ID: 12625032750
56:  RERUN_FAILED_ONLY: true
...

119:  ##[group]Run sudo apt update
120:  �[36;1msudo apt update�[0m
121:  �[36;1msudo apt install gh�[0m
122:  shell: /usr/bin/bash -e {0}
123:  env:
124:  GH_CLI_TOKEN: ***
125:  GH_CLI_TOKEN_PR: ***
126:  RUN_ID: 12625032750
127:  RERUN_FAILED_ONLY: true
...

175:  0 upgraded, 0 newly installed, 0 to remove and 53 not upgraded.
176:  ##[group]Run echo "$GH_CLI_TOKEN_PR" | gh auth login --with-token
177:  �[36;1mecho "$GH_CLI_TOKEN_PR" | gh auth login --with-token�[0m
178:  shell: /usr/bin/bash -e {0}
179:  env:
180:  GH_CLI_TOKEN: ***
181:  GH_CLI_TOKEN_PR: ***
182:  RUN_ID: 12625032750
183:  RERUN_FAILED_ONLY: true
184:  RUN_ATTEMPT: 1
185:  ##[endgroup]
186:  error validating token: missing required scope 'read:org'
187:  ##[error]Process completed with exit code 1.

✨ CI feedback usage guide:

The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
The tool analyzes the failed checks and provides several feedbacks:

  • Failed stage
  • Failed test name
  • Failure summary
  • Relevant error logs

In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

/checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"

where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

Configuration options

  • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
  • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
  • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
  • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
  • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

See more information about the checks tool in the docs.

Signed-off-by: Viet Nguyen Duc <[email protected]>
@VietND96 VietND96 force-pushed the runner-ubuntu-2404 branch from c5bdc16 to 376388e Compare January 6, 2025 02:21
@VietND96 VietND96 merged commit 9901ef7 into trunk Jan 6, 2025
36 checks passed
@VietND96 VietND96 deleted the runner-ubuntu-2404 branch January 6, 2025 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant