Docker: Unified node config session-timeout from generated TOML file (#…

…2598) Signed-off-by: Viet Nguyen Duc <[email protected]>
SeleniumHQ · Jan 20, 2025 · 7f756c1 · 7f756c1
1 parent d43142d
commit 7f756c1
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/NodeBase/generate_config b/NodeBase/generate_config
@@ -44,7 +44,7 @@ if [[ -z "${SE_NODE_GRID_URL}" ]]; then
 else
 	echo "grid-url = \"${SE_NODE_GRID_URL}\"" >>"$FILENAME"
 fi
-echo "session-timeout = \"${SE_NODE_SESSION_TIMEOUT}\"" >>"$FILENAME"
+echo "session-timeout = ${SE_NODE_SESSION_TIMEOUT}" >>"$FILENAME"
 echo "override-max-sessions = ${SE_NODE_OVERRIDE_MAX_SESSIONS}" >>"$FILENAME"
 echo "detect-drivers = false" >>"$FILENAME"
 echo "drain-after-session-count = ${DRAIN_AFTER_SESSION_COUNT:-$SE_DRAIN_AFTER_SESSION_COUNT}" >>"$FILENAME"

diff --git a/NodeBase/start-selenium-node.sh b/NodeBase/start-selenium-node.sh
@@ -53,10 +53,6 @@ if [[ -z "${SE_EVENT_BUS_SUBSCRIBE_PORT}" ]]; then
   exit 1
 fi
 
-if [ ! -z "$SE_NODE_SESSION_TIMEOUT" ]; then
-  append_se_opts "--session-timeout" "${SE_NODE_SESSION_TIMEOUT}"
-fi
-
 if [ ! -z "$SE_NODE_ENABLE_MANAGED_DOWNLOADS" ]; then
   append_se_opts "--enable-managed-downloads" "${SE_NODE_ENABLE_MANAGED_DOWNLOADS}"
 fi

diff --git a/Standalone/generate_config b/Standalone/generate_config
@@ -25,7 +25,7 @@ if [[ -z "${SE_NODE_GRID_URL}" ]]; then
 else
 	echo "grid-url = \"${SE_NODE_GRID_URL}\"" >>"$FILENAME"
 fi
-echo "session-timeout = \"${SE_NODE_SESSION_TIMEOUT}\"" >>"$FILENAME"
+echo "session-timeout = ${SE_NODE_SESSION_TIMEOUT}" >>"$FILENAME"
 echo "override-max-sessions = ${SE_NODE_OVERRIDE_MAX_SESSIONS}" >>"$FILENAME"
 echo "detect-drivers = false" >>"$FILENAME"
 echo "drain-after-session-count = ${DRAIN_AFTER_SESSION_COUNT:-$SE_DRAIN_AFTER_SESSION_COUNT}" >>"$FILENAME"