874 sqforms readonlyfield update component #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mudassar-Raza
requested review from
20BBrown14,
laurelbean and
hvilander
as code owners
laurelbean
approved these changes
Mar 28, 2023
aharpt
approved these changes
Mar 29, 2023
malikfarhan183
approved these changes
Mar 30, 2023
malikfarhan183
approved these changes
Mar 30, 2023
|
In your loom it looks like the label briefly uses a teal styling like it is actionable. Is this correct? Is this how it should work? Looking at the Figma it looks like the value could be clickable to copy, but the label should never look actionable. |
|
Yes, this seems right. The label should not look actionable. |
Make field label not look actionable BREAKING CHANGE: 🧨 No ✅ Closes: #874
laurelbean
added a commit
that referenced
this pull request
Jul 21, 2023
* feat: Updated Group Checkbox State Colors (#854) Co-authored-by: Farhan Abdul <[email protected]> * SSR-163: SQForms: Masked Read Only Field - Update component (#856) * feat: 🎸 Update SQForm Masked TextField (#866) * feat: 🎸 Update SQForm Masked TextField Updated font size and font weight BREAKING CHANGE: 🧨 no ✅ Closes: #865 * feat: 🎸 Update SQForm masked TextField Updated font weight and size BREAKING CHANGE: 🧨 No ✅ Closes: #865 --------- Co-authored-by: Mudassar Raza <[email protected]> * feat: SSR-161 SQFormsDropdown - Update component (#867) * feat: SQFormsDropdown - Update component * feat: move fontweight into classes * feat: 🎸 Update Component Multi-Select (#869) * feat: 🎸 Update Component Multi-Select Updated font weight and font size BREAKING CHANGE: 🧨 No ✅ Closes: #868 * fix: 🐛 Variant property into Form Control Positioned field title to the left as it was too far to the right side BREAKING CHANGE: 🧨 n ✅ Closes: #868 --------- Co-authored-by: Mudassar Raza <[email protected]> * 874 sqforms readonlyfield update component (#875) * feat: 🎸 ReadOnlyField-Update Component Removed underline and updated font weight BREAKING CHANGE: 🧨 n ✅ Closes: #874 * feat: 🎸 ReadOnlyField-Update Component Removed underline and updated font weight BREAKING CHANGE: 🧨 n ✅ Closes: #874 * feat: 🎸 ReadOnlyField-Update Component Removed underline and updated font weight BREAKING CHANGE: 🧨 No ✅ Closes: #874 * feat: 🎸 ReadOnlyField-Update Component Make field label not look actionable BREAKING CHANGE: 🧨 No ✅ Closes: #874 --------- Co-authored-by: Mudassar Raza <[email protected]> * style: 💄 SQForms: MultiValue - Update component (#878) * style: 💄 SQForms: MultiValue - Update component ✅ Closes: SSR-166 * style: 💄 Adding Variable for Input Size ✅ Closes: SSR-166 * style: 💄 Updating Code and Move some general Code in scplus-sha ✅ Closes: SSR-166 --------- Co-authored-by: Farhan Abdul <[email protected]> * chore: 🤖 Update to latest SCPlus Shared Components Updating to the latest version of SCPlus Shared Components * chore: 🤖 Remove redundant story name Since the name of the story is already 'Default' setting the story name to the same is unnecessary --------- Co-authored-by: Malik Abdul Farhan <[email protected]> Co-authored-by: Farhan Abdul <[email protected]> Co-authored-by: asim-sqfe <[email protected]> Co-authored-by: Mudassar-Raza <[email protected]> Co-authored-by: Mudassar Raza <[email protected]> Co-authored-by: Laurel Bean <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the current implementation of the ReadOnlyField with added specifications. Here is the current implementation of this SQForm: Webpack App (this is an example link)
Design reference: SC3 DESIGN LIBRARY
Typography: SC3 DESIGN LIBRARY
Color: SC3 DESIGN LIBRARY
Default:
Label: Text Style: Label 12 px Weight: 400
Value: Text Style: Value 14px Weight: 600 Semi-bold
Note: Underline in the read-only needs to be removed
Loom Link: Loom
closes: #874