feat: 🎸 SQFormRadioButtonGroup accepts React Element child arr #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQFormRadioButtonGroup accepts children in shape of array of React Elements ✅ Closes: #693
|
6 minute loom video? Burn the witch! Also, looks good to me after fixing the failed tests. I think checking that every item is a valid react element should be fine. |
Yeah, I'm trying to figure out why the tests failed for stories I didn't touch... |
ope, it's cause I got rid of the |
add onBlur handler back ✅ Closes: 693
aharpt
approved these changes
Jun 30, 2022
SeanGroff
approved these changes
Jun 30, 2022
20BBrown14
approved these changes
Jul 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQFormRadioButtonGroup accepts children in shape of array of React
Elements
✅ Closes: #693
Loom demo
This addresses an issue originating from AQE2