Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PropType validations are missing in some components #95

Closed
20BBrown14 opened this issue Feb 18, 2021 · 1 comment · Fixed by #98
Closed

PropType validations are missing in some components #95

20BBrown14 opened this issue Feb 18, 2021 · 1 comment · Fixed by #98
Assignees
@20BBrown14
Labels
good first issue Good for newcomers help wanted Extra attention is needed released

Comments

@20BBrown14
Copy link
Contributor

Some components are missing proptype validations. For instance, SQFormDialog is missing enableReinitialize in the proptypes validation. Super easy fix and super easy good first issue. Perhaps whenever this gets addressed all the components can be gone through to make sure all our props have the proper validation.

This isn't a major issue but it should be fixed to ensure that we get proptype warnings when necessary. Also, some of documentation is lacking in place so people go to the code to look for proptypes and if a prop isn't in the validation declarations they may think that it doesn't take that prop.
@20BBrown14 20BBrown14 added the good first issue Good for newcomers label Feb 18, 2021
@SeanGroff SeanGroff added the help wanted Extra attention is needed label Feb 18, 2021
@20BBrown14 20BBrown14 self-assigned this Feb 24, 2021
20BBrown14 added a commit that referenced this issue Feb 24, 2021
@20BBrown14
fix: 🐛 Added missing proptype documentation
bb6486d 
Added missing proptype documentation including missing props, default
values, and descriptions.

✅ Closes: #95
20BBrown14 added a commit that referenced this issue Feb 24, 2021
@20BBrown14
fix: 🐛 Added missing proptype documentation
81be624 
Added missing proptype documentation including missing props, default
values, and descriptions.

✅ Closes: #95
@20BBrown14 20BBrown14 mentioned this issue Feb 24, 2021
Merged
SeanGroff pushed a commit that referenced this issue Feb 24, 2021
@semantic-release-bot
chore(release): 3.1.1 [skip ci]
755d6e9 
### [3.1.1](v3.1.0...v3.1.1) (2021-02-24)

### Bug Fixes

* 🐛 Added missing proptype documentation ([81be624](81be624)), closes [#95](#95)
@SeanGroff
Copy link
Contributor

🎉 This issue has been resolved in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@20BBrown14 20BBrown14

Labels
good first issue Good for newcomers help wanted Extra attention is needed released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 Added missing proptype documentation SelectQuoteLabs/SQForm
2 participants
@SeanGroff @20BBrown14