Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tertiary Button on SQFormDialog needs additional padding and onClick handler #643

Closed
aharpt opened this issue Feb 28, 2022 · 0 comments · Fixed by #644
Closed

Tertiary Button on SQFormDialog needs additional padding and onClick handler #643

aharpt opened this issue Feb 28, 2022 · 0 comments · Fixed by #644
Assignees
@aharpt

Comments

@aharpt
Copy link
Contributor

aharpt commented Feb 28, 2022 •
edited
Loading

The Tertiary button on the SQFormDialog needs additional padding (20px) between it and the main primary button to adhere to our UX guidelines. We also need to give it its own click handler.
@aharpt aharpt self-assigned this Feb 28, 2022
aharpt added a commit that referenced this issue Feb 28, 2022
@aharpt
feat: 🎸 Add "onTertiaryClick" click handler to SQFormDialog
8718a4f 
Add "onTertiaryClick" click handler prop to SQFormDialog component

✅ Closes: #643
@aharpt aharpt mentioned this issue Feb 28, 2022
Merged
ghost pushed a commit that referenced this issue Feb 28, 2022
@semantic-release-bot
chore(release): 7.4.0 [skip ci]
0343f66 
## [7.4.0](v7.3.0...v7.4.0) (2022-02-28)

### Features

* 🎸 Add "onTertiaryClick" click handler to SQFormDialog ([8718a4f](8718a4f)), closes [#643](#643)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aharpt aharpt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: 🎸 Add "onTertiaryClick" click handler to SQFormDialog SelectQuoteLabs/SQForm
1 participant
@aharpt