Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update multi select to accept onChange handler #53

Closed
ghost opened this issue Jan 4, 2021 · 2 comments · Fixed by #62
Closed

update multi select to accept onChange handler #53

ghost opened this issue Jan 4, 2021 · 2 comments · Fixed by #62
Assignees
@Chris-Boyle
Labels
enhancement New feature or request help wanted Extra attention is needed released

Comments

@ghost
Copy link

ghost commented Jan 4, 2021

Currently most of our components have an onChange prop that can be passed but the multiselect component does not. We would like to have an onChange handler so we can conditionally show/hide other fields in the form based on what options are selected in the multi-select component.
@SeanGroff SeanGroff added enhancement New feature or request help wanted Extra attention is needed labels Jan 4, 2021
@Chris-Boyle
Copy link
Contributor

I can start looking at this.

Chris-Boyle added a commit that referenced this issue Jan 11, 2021
@Chris-Boyle
feat: 🎸 Added onChange handler to multiselect component
dff40e6 
✅ Closes: #53
@Chris-Boyle Chris-Boyle mentioned this issue Jan 11, 2021
Merged
Chris-Boyle added a commit that referenced this issue Jan 11, 2021
@Chris-Boyle
feat: 🎸 Added proptype
4aa802b 
✅ Closes: #53
Chris-Boyle added a commit that referenced this issue Jan 12, 2021
@Chris-Boyle
feat: 🎸 Updated code to call onChange and default handler
f4ecf85 
✅ Closes: #53
SeanGroff pushed a commit that referenced this issue Jan 12, 2021
@semantic-release-bot
chore(release): 2.6.0 [skip ci]
5161f99 
## [2.6.0](v2.5.0...v2.6.0) (2021-01-12)

### Features

* 🎸 Added onChange handler to multiselect component ([dff40e6](dff40e6)), closes [#53](#53)
* 🎸 Added proptype ([4aa802b](4aa802b)), closes [#53](#53)
* 🎸 Updated code to call onChange and default handler ([f4ecf85](f4ecf85)), closes [#53](#53)
@SeanGroff
Copy link
Contributor

🎉 This issue has been resolved in version 2.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Boyle Chris-Boyle

Labels
enhancement New feature or request help wanted Extra attention is needed released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: 🎸 Added onChange handler to multiselect component SSC-107 SelectQuoteLabs/SQForm
2 participants
@SeanGroff @Chris-Boyle