Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update id on components to be name instead of label #318

Closed
Chris-Boyle opened this issue Jun 25, 2021 · 0 comments · Fixed by #319
Closed

Update id on components to be name instead of label #318

Chris-Boyle opened this issue Jun 25, 2021 · 0 comments · Fixed by #319
Assignees
@Chris-Boyle

Comments

@Chris-Boyle
Copy link
Contributor

Chris-Boyle commented Jun 25, 2021 •
edited
Loading

I have two fields that both contain a county value. One is in the mailing address section and one in the personal information section. This is causing this warning for having duplicate id values. In Our ReadOnlyComponent it looks like we are setting the id value to just be the label. We need to do is make that id more unique.

Name appears to be a better option since the names are pretty unique to their use case.

image
@Chris-Boyle Chris-Boyle self-assigned this Jun 25, 2021
Chris-Boyle added a commit that referenced this issue Jun 25, 2021
@Chris-Boyle
fix: 🐛 Updated id values to name instead of label for more uniq
14764b9 
Updated id values to name instead of label for more uniqueness

✅ Closes: #318
@Chris-Boyle Chris-Boyle mentioned this issue Jun 25, 2021
Merged
SeanGroff pushed a commit that referenced this issue Jun 25, 2021
@semantic-release-bot
chore(release): 5.0.1 [skip ci]
9d99fa7 
### [5.0.1](v5.0.0...v5.0.1) (2021-06-25)

### Bug Fixes

* 🐛 Updated id values to name instead of label for more uniq ([14764b9](14764b9)), closes [#318](#318)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Boyle Chris-Boyle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 Updated id values to name instead of label for more uniq SelectQuoteLabs/SQForm
1 participant
@Chris-Boyle