Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty option label - - is not showing for SQFormDropdown #31

Closed
shahzaib-haider1 opened this issue Dec 22, 2020 · 1 comment · Fixed by #34
Closed

Empty option label - - is not showing for SQFormDropdown #31

shahzaib-haider1 opened this issue Dec 22, 2020 · 1 comment · Fixed by #34
Assignees
@SeanGroff
Labels
bug Something isn't working released

Comments

@shahzaib-haider1
Copy link

we are confronting an issue while using SQFormDropdown, on initial rendering, or while changing the option to empty, option label - - is not showing but selecting a value for it.

Here is loom video
https://www.loom.com/share/9728215a874342a8bbf4895b55f18a4a
@SeanGroff SeanGroff self-assigned this Dec 22, 2020
@SeanGroff SeanGroff added the bug Something isn't working label Dec 22, 2020
SeanGroff pushed a commit that referenced this issue Dec 22, 2020
fix: 🐛 Displays - - when empty, displays label instead of value
40e5243 
When the dropdown doesn't contain a selected value the empty label - -
will render in the field. When an option is selected, the human-readable
label will render in the field instead of the value.

✅ Closes: #31
@SeanGroff SeanGroff mentioned this issue Dec 22, 2020
Merged
github-actions bot pushed a commit that referenced this issue Dec 22, 2020
@semantic-release-bot
chore(release): 2.0.2 [skip ci]
ee41298 
### [2.0.2](v2.0.1...v2.0.2) (2020-12-22)

### Bug Fixes

* 🐛 Displays - - when empty, displays label instead of value ([40e5243](40e5243)), closes [#31](#31)
@github-actions
Copy link

🎉 This issue has been resolved in version 2.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SeanGroff SeanGroff

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 Displays - - when empty, displays label instead of value SelectQuoteLabs/SQForm
2 participants
@SeanGroff @shahzaib-haider1