Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused props in SQFormDialogStepper #279

Closed
codyarose opened this issue May 22, 2021 · 0 comments · Fixed by #328
Closed

Unused props in SQFormDialogStepper #279

codyarose opened this issue May 22, 2021 · 0 comments · Fixed by #328
Assignees
@Chris-Boyle
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@codyarose
Copy link
Contributor

The props onSave and saveButtonText are listed in the props and/or prop-types, but neither are actually used in the component. I'm guessing this is legacy code that should be removed?

SQForm/src/components/SQFormDialogStepper/SQFormDialogStepper.js

Line 75 in ea4859d

export function SQFormDialogStepper({

@codyarose codyarose added bug Something isn't working help wanted Extra attention is needed labels May 22, 2021
@laurelbean laurelbean added the good first issue Good for newcomers label May 25, 2021
@Chris-Boyle Chris-Boyle self-assigned this Jun 29, 2021
Chris-Boyle added a commit that referenced this issue Jun 29, 2021
@Chris-Boyle
fix: 🐛 Removed unused props from the stepper component
ad6df58 
✅ Closes: #279
@Chris-Boyle Chris-Boyle mentioned this issue Jun 29, 2021
Merged
SeanGroff pushed a commit that referenced this issue Jun 30, 2021
@semantic-release-bot
chore(release): 5.0.2 [skip ci]
9445eda 
### [5.0.2](v5.0.1...v5.0.2) (2021-06-30)

### Bug Fixes

* 🐛 Removed unused props from the stepper component ([ad6df58](ad6df58)), closes [#279](#279)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Boyle Chris-Boyle

Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 Removed unused props from the stepper component SelectQuoteLabs/SQForm
3 participants
@laurelbean @Chris-Boyle @codyarose