Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQFormAutocomplete has an empty option in the list of options #179

Closed
Chris-Boyle opened this issue Apr 2, 2021 · 1 comment · Fixed by #187
Closed

SQFormAutocomplete has an empty option in the list of options #179

Chris-Boyle opened this issue Apr 2, 2021 · 1 comment · Fixed by #187
Assignees
@20BBrown14

Comments

@Chris-Boyle
Copy link
Contributor

Chris-Boyle commented Apr 2, 2021 •
edited
Loading

A recent change to SQFormAutocomplete fixed a warning about the component being controlled/uncontrolled by adding an empty option. This solved the warning but now gives us an empty option at the bottom of the dropdown. This may not be desirable to most consumers so we should look into how we can omit the empty option and still not throw warnings about the component state going from controlled/uncontrolled.

introduced by: https://github.com/SelectQuoteLabs/SQForm/pull/146/files

image
@20BBrown14
Copy link
Contributor

This one's on me haha. For context here is an explanation of why the empty option is there but obviously we should try to avoid this if at all possible

#146 (comment)

20BBrown14 added a commit that referenced this issue Apr 5, 2021
@20BBrown14
fix: 🐛 SQFormautocomplete autocomplete displayEmpty prop
1d5e34f 
Added a displayempty prop to SQFormAutocomplete that keeps the empty
option from displaying when not wanted. Able to preserve the
functionality that kept controlled/uncontrolled warnings at bay.

✅ Closes: #179
@20BBrown14 20BBrown14 self-assigned this Apr 5, 2021
@20BBrown14 20BBrown14 mentioned this issue Apr 5, 2021
Merged
20BBrown14 added a commit that referenced this issue Apr 5, 2021
@20BBrown14
fix: 🐛 SQFormautocomplete autocomplete displayEmpty prop
ecb9e32 
Added a displayempty prop to SQFormAutocomplete that keeps the empty
option from displaying when not wanted. Able to preserve the
functionality that kept controlled/uncontrolled warnings at bay.

✅ Closes: #179
SeanGroff pushed a commit that referenced this issue Apr 6, 2021
@semantic-release-bot
chore(release): 4.5.2 [skip ci]
ade7086 
### [4.5.2](v4.5.1...v4.5.2) (2021-04-06)

### Bug Fixes

* 🐛 SQFormautocomplete autocomplete displayEmpty prop ([ecb9e32](ecb9e32)), closes [#179](#179)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@20BBrown14 20BBrown14

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 SQFormautocomplete autocomplete displayEmpty prop SelectQuoteLabs/SQForm
2 participants
@Chris-Boyle @20BBrown14