Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook GH Action Failing due to error in a Story #105

Closed
SeanGroff opened this issue Mar 2, 2021 · 2 comments · Fixed by #106
Closed

Storybook GH Action Failing due to error in a Story #105

SeanGroff opened this issue Mar 2, 2021 · 2 comments · Fixed by #106
Assignees
@codyarose
Labels
help wanted Extra attention is needed in progress released

Comments

@SeanGroff
Copy link
Contributor

Our Storybook GH action is failing due to an error in one of our stories.
Can someone run Storybook locally, and view the failing story in the screenshot? The error should be in the console if it doesn't appear in the browser window.

Please make this commit a chore as we don't need to bump the version for this. Or maybe this is an actual bug and we need to fix the component itself. In that case, do a fix commit.

Thanks!

Screen Shot 2021-03-02 at 4 44 18 PM
@SeanGroff SeanGroff added the help wanted Extra attention is needed label Mar 2, 2021
@codyarose codyarose self-assigned this Mar 3, 2021
@codyarose
Copy link
Contributor

Looks like that's from my PR #103 on SQFormTextField.
I've found what's causing it and a fix, so I'll put together a PR

codyarose pushed a commit that referenced this issue Mar 3, 2021
fix: 🐛 add optional chaining to initial value of useState
c7a0f4f 
The initial `useState` value of `valueLength` didn't account for a
field's value being `undefined`

✅ Closes: #105
@codyarose codyarose mentioned this issue Mar 3, 2021
Merged
SeanGroff pushed a commit that referenced this issue Mar 3, 2021
@semantic-release-bot
chore(release): 3.3.1 [skip ci]
9b56f8d 
### [3.3.1](v3.3.0...v3.3.1) (2021-03-03)

### Bug Fixes

* 🐛 add optional chaining to initial value of useState ([c7a0f4f](c7a0f4f)), closes [#105](#105)
@SeanGroff
Copy link
Contributor Author

🎉 This issue has been resolved in version 3.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyarose codyarose

Labels
help wanted Extra attention is needed in progress released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: 🐛 add optional chaining to initial value of character counter SelectQuoteLabs/SQForm
2 participants
@SeanGroff @codyarose