fix: 🐛 ?? operator instead of || for grid spacing prop check

Use nullish coalescing operator (??) instead of or (||) operator to check for existence of `spacing` value which can be 0 which is falsy causing unexpected values. ✅ Closes: 114
SelectQuoteLabs · Mar 8, 2021 · 1c061d7 · 1c061d7
1 parent 4c01409
commit 1c061d7
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/components/SQForm/SQForm.js b/src/components/SQForm/SQForm.js
@@ -43,7 +43,7 @@ function SQForm({
             <Grid
               {...muiGridProps}
               container
-              spacing={muiGridProps.spacing || 2}
+              spacing={muiGridProps.spacing ?? 2}
             >
               {children}
             </Grid>

diff --git a/src/components/SQFormDialog/SQFormDialogInner.js b/src/components/SQFormDialog/SQFormDialogInner.js
@@ -81,7 +81,7 @@ function SQFormDialogInner({
             <Grid
               {...muiGridProps}
               container
-              spacing={muiGridProps.spacing || 2}
+              spacing={muiGridProps.spacing ?? 2}
             >
               {children}
             </Grid>

diff --git a/src/components/SQFormDialogStepper/SQFormDialogStepper.js b/src/components/SQFormDialogStepper/SQFormDialogStepper.js
@@ -221,7 +221,7 @@ export function SQFormDialogStepper({
               <Grid
                 {...muiGridProps}
                 container
-                spacing={muiGridProps.spacing || 3}
+                spacing={muiGridProps.spacing ?? 3}
                 justify="center"
               >
                 {currentChild}