Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin protobuf < 4 #686

Merged
merged 1 commit into from
May 31, 2022
Merged

Pin protobuf < 4 #686

merged 1 commit into from
May 31, 2022

Conversation

mauicv
Copy link
Contributor

@mauicv mauicv commented May 30, 2022

Fixes ray dependency issue in CI due to protobuf release 4.21.1. Should be reverted once this issue is resolved.

@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #686 (f3a4122) into master (b3b7423) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #686   +/-   ##
=======================================
  Coverage   80.55%   80.55%           
=======================================
  Files         105      105           
  Lines       11790    11790           
=======================================
  Hits         9497     9497           
  Misses       2293     2293           

@ddelange
Copy link

a fix was merged but is not yet released: ray-project/ray#25211

@mauicv mauicv merged commit b779fee into SeldonIO:master May 31, 2022
@ddelange
Copy link

ddelange commented Jun 9, 2022

fyi, ray 1.13.0 has just been released with a protobuf fix

mauicv added a commit that referenced this pull request Jun 10, 2022
@mauicv mauicv mentioned this pull request Jun 10, 2022
@mauicv
Copy link
Contributor Author

mauicv commented Jun 10, 2022

@ddelange, Great! Thanks for letting us know!

mauicv added a commit that referenced this pull request Jun 10, 2022
Revert "Pin protobuf < 4 (#686)"

This reverts commit b779fee.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants