Fix bugs with passing images_background to AnchorImage #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklaise
commented
Nov 25, 2021
| @@ -221,13 +221,12 @@ def perturbation( | |||
| segments_mask[:, anchor] = 1 | |||
|
|
|||
| # for each sample, need to sample one of the background images if provided | |||
| if self.images_background: | |||
| if self.images_background is not None: | |||
There was a problem hiding this comment.
self.images_background is either None or np.ndarray so we must check explicitly for None as np.ndarray doesn't have a working __bool__ method.
jklaise
commented
Nov 25, 2021
| @@ -247,7 +246,7 @@ def perturbation( | |||
| mask = np.zeros(segments.shape).astype(bool) | |||
| for superpixel in to_perturb: | |||
| mask[segments == superpixel] = True | |||
| if background_idx: | |||
| if background_idx is not None: | |||
There was a problem hiding this comment.
The main bug. Here background_idx can be 0 but in the previous version it would cause it to go down this (wrong) branch and end up using fudged_image which is not defined. The fix is to explicitly check for None.
jklaise
commented
Nov 25, 2021
| backgrounds = np.random.choice( | ||
| range(len(self.images_background)), | ||
| segments_mask.shape[0], | ||
| replace=True, | ||
| ) | ||
| segments_mask = np.hstack((segments_mask, backgrounds.reshape(-1, 1))) |
There was a problem hiding this comment.
This line appears to be completely random and just doesn't work.
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
==========================================
+ Coverage 82.46% 82.50% +0.03%
==========================================
Files 77 77
Lines 10416 10418 +2
==========================================
+ Hits 8590 8595 +5
+ Misses 1826 1823 -3
|
|
Added a simple test by parametrizing |
RobertSamoilescu
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #540.
I have manually checked that the code now works passing an array of
images_backgroundand that the proposed anchor is actually superimposed on these background images. I will see if an automated test can also be written relatively easily.