Bug fix: Include forward_args in self.model function calls in intergrated_gradients.py

[sanjass]

Bug report + fix: forward_kwargs not used in all self.model calls in integrated_gradients.py
#524

[jklaise]

@sanjass the tests are failing because we also pass in forward_kwargs when it is None. We would need to add the same logic to these calls as here:

alibi/alibi/explainers/integrated_gradients.py

Lines 143 to 146 in 6100135

	if forward_kwargs is None:
	preds = model(x)
	else:
	preds = model(x, **forward_kwargs)

Given the repetition I think it would be good to split this out into a small utility function (or actually, would be good to check if we could just substitute None for the empty dictionary {} and it might run without having to do this check).

[sanjass]

I see, I pushed a change as follows:

if forward_kwargs is None:
    forward_kwargs = {}

and replaced If forward_kwargs is not None-> if forward_kwargs
also removed if forward_kwargs is None and passed **forward_kwargs as before

Didn't get to run the checks though

[jklaise]

Thanks! Changes look good, I will rerun the IG notebooks (especially the transformers one) before merging.

[codecov]

Codecov Report

Merging #525 (ea3f40a) into master (6100135) will decrease coverage by 0.02%.
The diff coverage is 81.25%.

@@            Coverage Diff             @@
##           master     #525      +/-   ##
==========================================
- Coverage   82.34%   82.32%   -0.03%     
==========================================
  Files          76       76              
  Lines       10334    10350      +16     
==========================================
+ Hits         8510     8521      +11     
- Misses       1824     1829       +5     

Impacted Files	Coverage Δ
alibi/explainers/integrated_gradients.py	88.91% <81.25%> (-0.89%)	⬇️

[jklaise]

@sanjass just a suggestion, if you also do pip install -r requirements/dev.txt and run flake8 alibi from the repo source you can see all the linting errors and fix them locally :)

[sanjass]

Yeah, did something like that but my previous fix introduced a different flake8 error and I didn't double check lol. Also I'm editing in the github editor directly. Anyways hopefully this finally works

[RobertSamoilescu]

@sanjass, we will be working on issue #527 before merging this PR.

[jklaise]

@sanjass thank you for your contribution! And thanks for the extra review @RobertSamoilescu!