Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit sphinx-autodoc-typehints upper bound #633

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Limit sphinx-autodoc-typehints upper bound #633

merged 1 commit into from
Sep 27, 2022

Conversation

ascillitoe
Copy link
Contributor

@ascillitoe ascillitoe commented Sep 27, 2022

Limit sphinx-autodoc-typehints to <1.19.3 due to tox-dev/sphinx-autodoc-typehints#259 and tox-dev/sphinx-autodoc-typehints#260.

alibi equivalent: SeldonIO/alibi#790

@ascillitoe
Copy link
Contributor Author

@jklaise the docs CI is now passing 👍🏻

@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2022

Codecov Report

Merging #633 (af3be06) into master (2683721) will decrease coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #633      +/-   ##
==========================================
- Coverage   77.96%   77.88%   -0.08%     
==========================================
  Files         123      123              
  Lines        8749     8714      -35     
==========================================
- Hits         6821     6787      -34     
+ Misses       1928     1927       -1     
Flag Coverage Δ
macos-latest-3.10.6 ?
ubuntu-latest-3.10.6 ?
ubuntu-latest-3.7 77.75% <ø> (ø)
ubuntu-latest-3.8 77.79% <ø> (ø)
ubuntu-latest-3.9 77.79% <ø> (ø)
windows-latest-3.9 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
alibi_detect/utils/frameworks.py 87.50% <0.00%> (-4.17%) ⬇️
alibi_detect/utils/missing_optional_dependency.py 94.28% <0.00%> (-0.16%) ⬇️
alibi_detect/datasets.py 68.55% <0.00%> (-0.14%) ⬇️
alibi_detect/saving/schemas.py 99.20% <0.00%> (-0.05%) ⬇️
alibi_detect/utils/fetching/fetching.py 0.00% <0.00%> (ø)
alibi_detect/cd/base.py 91.14% <0.00%> (+0.21%) ⬆️
alibi_detect/od/vae.py 90.36% <0.00%> (+1.07%) ⬆️

@ascillitoe ascillitoe merged commit c7be430 into SeldonIO:master Sep 27, 2022
@ascillitoe ascillitoe deleted the fix/sphinx-autodoc-typehints branch September 27, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants