Fix bugs introduced in last PR #50 #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…8s resource templates arent being replaced, so replace with dash
SebastianScherer88
changed the title
SebastianScherer88
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two bugs introduced in PR #50
Fix 1
The underscore in
torch_ddpgets replaced when populating thebase_nameattribute of theTorchDDPComponentclass instance, but is not being replaced when building the k8s service related creation and deletion templates.Fix is to use dashes in all
COMPONENT_IMPLEMENTATIONenum values.Fix 2
Adding constant for the dag template names and additional step to retrieve the workflow template's inner dag template when (re-)building inputs.